CalibratedSensor: settle time as parameter #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for contributing this. You're completely right that the Encoder class does not obey the contract of the Sensor superclass - that's not really implemented correctly one could say. As a consequence the CalibratedSensor had the bug you found - I believe it was developed using a magnetic sensor which would not have manifested this problem. Thanks a lot for catching it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had some problems with the CalibratedSensor class when using with the new HybridStepper functionality.
Solution was to increase the settle time but as it was hard coded i made it a parameter.
Also my Encoder (which is a standard Mag enocoder with quadrature A/B interface) did output negative values with the
getMechanicalAngle-API which made the LUT not work when turning negative. I added afmodfcall to prevent that.